Fix mypy types changed by blessed update - #191
Open
thomasballinger wants to merge 1 commit into
Open
thomasballinger wants to merge 1 commit into
thomasballinger wants to merge 1 commit into
Conversation
jquast
reviewed
Sep 28, 2026
jquast
left a comment
jquast
left a comment
There was a problem hiding this comment.
sorry about mypy typing being poor with blessed. I have considered, now that blessed no longer depends on curses in any way, making it "singleton-free", and all terminal capabilities are now in a fixed database, I could replace a lot of the "magic getattr" with concrete, typed methods, like for this one.
This fixes the direct ones like move, but doesn't fix the really magic ones, like "bright_red_on_green_italic"
move_yx is much better than move for readability, anyway
|
|
||
| self.write(self.t.move_x(0)) | ||
| # Blessed's Terminal.move_x doesn't type this, see | ||
| # https://github.com/jquast/blessed/blob/master/tox.ini#L121-L130 |
There was a problem hiding this comment.
this hyperlink became out of date, suggest a commit-stable url for source code,
Suggested change
| # https://github.com/jquast/blessed/blob/master/tox.ini#L121-L130 | |
| # https://github.com/jquast/blessed/blob/362dbe2483d064b0fe7c3b3535c91bc6b6fa5345/tox.ini#L131-L135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.